Skip to content

Benchmarking Variable Rate Aggregator #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 15, 2025
Merged

Benchmarking Variable Rate Aggregator #1230

merged 16 commits into from
Sep 15, 2025

Conversation

@sivasathyaseeelan
Copy link
Contributor

@sivasathyaseeelan sivasathyaseeelan commented May 19, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@sivasathyaseeelan sivasathyaseeelan mentioned this pull request May 19, 2025
Merged
5 tasks
@ChrisRackauckas ChrisRackauckas mentioned this pull request May 20, 2025
Open
10 tasks
@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 5, 2025

Needs to rebase to run

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 6, 2025

Rebase, you have other changes in this PR.

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Jun 6, 2025 •
edited
Loading

Rebase, you have other changes in this PR.

Resolved all conflicts

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 6, 2025

The manifest needs a bump, and it needs to be run on v1.10

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Jun 6, 2025 •
edited
Loading

The manifest needs a bump, and it needs to be run on v1.10

I tried to bump but nothing is updated or resolved

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 6, 2025

needs a manifest bump

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Jun 6, 2025

needs a manifest bump

Bumped now!

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 10, 2025

Were you going to move this to the right folder?

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Jun 10, 2025

Were you going to move this to the right folder?

Yes I will move the tests

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Jun 10, 2025

Moved to HybridJump folder

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Sep 15, 2025

Rebase?

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Sep 15, 2025

Rebase?

Done 👍

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Sep 15, 2025

@isaacsas it looks like FRM is faster until about 5-10 jumps, which I find odd and likely something that can be fixed by some optimization, but seems to hold across a bunch of different benchmarks. But then Direct blows it away. FRM is also unstable for a lot more. So I think it makes sense to just default there.

@ChrisRackauckas ChrisRackauckas merged commit 19fb958 into SciML:master Sep 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sivasathyaseeelan @ChrisRackauckas